linux-kernel - Re: [PATCH] soc: fsl: qe: request pins non-exclusively

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <490B1A14-9DD0-4001-9F39-869F42F7AAA7@gmail.com>
Date:   Tue, 08 Nov 2022 08:20:38 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Qiang Zhao <qiang.zhao@....com>, Arnd Bergmann <arnd@...db.de>,
        Li Yang <leoyang.li@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linuxppc-dev@...ts.ozlabs.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] soc: fsl: qe: request pins non-exclusively

On November 8, 2022 2:50:07 AM PST, Linus Walleij <linus.walleij@...aro.org> wrote:
>On Tue, Nov 8, 2022 at 4:16 AM Dmitry Torokhov
><dmitry.torokhov@...il.com> wrote:
>
>> Commit 84582f9ed090 ("soc: fsl: qe: Avoid using gpio_to_desc()") changed
>> qe_pin_request() to request and hold GPIO corresponding to a given pin.
>> Unfortunately this does not work, as fhci-hcd requests these GPIOs
>> first, befor calling qe_pin_request() (see
>> drivers/usb/host/fhci-hcd.c::of_fhci_probe()).
>> To fix it change qe_pin_request() to request GPIOs non-exclusively, and
>> free them once the code determines GPIO controller and offset for each
>> GPIO/pin.
>>
>> Also reaching deep into gpiolib implementation is not the best idea. We
>> should either export gpio_chip_hwgpio() or keep converting to the global
>> gpio numbers space until we fix the driver to implement proper pin
>> control.
>>
>> Fixes: 84582f9ed090 ("soc: fsl: qe: Avoid using gpio_to_desc()")
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
>
>Wow! Thanks for fixing this!
>
>Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>
>I just sent that patch into the SoC patch tracker (soc@...nel.org)
>with a not to apply it directly, I suggest you do the same (or ask me
>to sign it off and send it).

I am not really plugged into soc patch/workflow so if you could do that that would be wonderful. 

Thanks!


-- 
Dmitry