linux-kernel - Re: [PATCH v5 08/24] sched: Introduce per memory space current virtual cpu id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <916c7a1f-fddd-77d6-6f91-6d3c196e1d86@efficios.com>
Date:   Tue, 8 Nov 2022 14:45:24 -0500
From:   Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Boqun Feng <boqun.feng@...il.com>,
        "H . Peter Anvin" <hpa@...or.com>, Paul Turner <pjt@...gle.com>,
        linux-api@...r.kernel.org, Christian Brauner <brauner@...nel.org>,
        Florian Weimer <fw@...eb.enyo.de>, David.Laight@...lab.com,
        carlos@...hat.com, Peter Oskolkov <posk@...k.io>,
        Alexander Mikhalitsyn <alexander@...alicyn.com>,
        Chris Kennelly <ckennelly@...gle.com>
Subject: Re: [PATCH v5 08/24] sched: Introduce per memory space current
 virtual cpu id

On 2022-11-08 08:00, Peter Zijlstra wrote:
> On Thu, Nov 03, 2022 at 04:03:43PM -0400, Mathieu Desnoyers wrote:
> 
>> diff --git a/fs/exec.c b/fs/exec.c
>> index 349a5da91efe..93eb88f4053b 100644
>> --- a/fs/exec.c
>> +++ b/fs/exec.c
>> @@ -1013,6 +1013,9 @@ static int exec_mmap(struct mm_struct *mm)
>>   	tsk->active_mm = mm;
>>   	tsk->mm = mm;
>>   	lru_gen_add_mm(mm);
>> +	mm_init_vcpu_lock(mm);
>> +	mm_init_vcpumask(mm);
>> +	mm_init_node_vcpumask(mm);
>>   	/*
>>   	 * This prevents preemption while active_mm is being loaded and
>>   	 * it and mm are being updated, which could cause problems for
> 
>> @@ -1150,6 +1154,9 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p,
>>   
>>   	mm->user_ns = get_user_ns(user_ns);
>>   	lru_gen_init_mm(mm);
>> +	mm_init_vcpu_lock(mm);
>> +	mm_init_vcpumask(mm);
>> +	mm_init_node_vcpumask(mm);
>>   	return mm;
>>   
>>   fail_nocontext:
> 
> Why isn't all that a single mm_init_vcpu(mm) or something ?

Good point, I'll update that.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com