linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11d29754-3e36-895b-e791-2c2f88c6dbed@linaro.org>
Date:   Tue, 8 Nov 2022 21:47:23 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Alex Elder <elder@...aro.org>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, andersson@...nel.org,
        agross@...nel.org
Cc:     devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc7280-idp: don't modify &ipa twice



On 08/11/2022 21:16, Alex Elder wrote:
> In "sc7280-idp.dts", the IPA node is modified after being defined.
> However that file includes "sc7280-idp.dtsi", which also modifies
> the IPA node (in the same way).  This only needs to be done in
> "sc7280-idp.dtsi".
> 
> Signed-off-by: Alex Elder <elder@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad
>   arch/arm64/boot/dts/qcom/sc7280-idp.dts | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> index 7559164cdda08..9ddfdfdd354ee 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
> @@ -61,11 +61,6 @@ &bluetooth {
>   	vddio-supply = <&vreg_l19b_1p8>;
>   };
>   
> -&ipa {
> -	status = "okay";
> -	modem-init;
> -};
> -
>   &pmk8350_rtc {
>   	status = "okay";
>   };