[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP-5=fW+vsMEVCoGbouMbH0GQ875KsMKwJ9NKhCecYd7PFESWA@mail.gmail.com>
Date: Tue, 8 Nov 2022 15:14:39 -0800
From: Ian Rogers <irogers@...gle.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
LKML <linux-kernel@...r.kernel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
linux-perf-users@...r.kernel.org,
Kan Liang <kan.liang@...ux.intel.com>,
Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
James Clark <james.clark@....com>
Subject: Re: [PATCH 2/9] perf stat: Increase metric length to align outputs
On Mon, Nov 7, 2022 at 1:33 PM Namhyung Kim <namhyung@...nel.org> wrote:
>
> When perf stat is called with very detailed events, the output doesn't
> align well like below:
>
> $ sudo perf stat -a -ddd sleep 1
>
> Performance counter stats for 'system wide':
>
> 8,020.23 msec cpu-clock # 7.997 CPUs utilized
> 3,970 context-switches # 494.998 /sec
> 169 cpu-migrations # 21.072 /sec
> 586 page-faults # 73.065 /sec
> 649,568,060 cycles # 0.081 GHz (30.42%)
> 304,044,345 instructions # 0.47 insn per cycle (38.40%)
> 60,313,022 branches # 7.520 M/sec (38.89%)
> 2,766,919 branch-misses # 4.59% of all branches (39.26%)
> 74,422,951 L1-dcache-loads # 9.279 M/sec (39.39%)
> 8,025,568 L1-dcache-load-misses # 10.78% of all L1-dcache accesses (39.22%)
> 3,314,995 LLC-loads # 413.329 K/sec (30.83%)
> 1,225,619 LLC-load-misses # 36.97% of all LL-cache accesses (30.45%)
> <not supported> L1-icache-loads
> 20,420,493 L1-icache-load-misses # 0.00% of all L1-icache accesses (30.29%)
> 58,017,947 dTLB-loads # 7.234 M/sec (30.37%)
> 704,677 dTLB-load-misses # 1.21% of all dTLB cache accesses (30.27%)
> 234,225 iTLB-loads # 29.204 K/sec (30.29%)
> 417,166 iTLB-load-misses # 178.10% of all iTLB cache accesses (30.32%)
> <not supported> L1-dcache-prefetches
> <not supported> L1-dcache-prefetch-misses
>
> 1.002947355 seconds time elapsed
>
> Increase the METRIC_LEN by 3 so that it can align properly.
>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
Acked-by: Ian Rogers <irogers@...gle.com>
Thanks,
Ian
> ---
> tools/perf/util/stat-display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index ea41e6308c50..17d656566cd9 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -218,7 +218,7 @@ struct outstate {
> struct evsel *evsel;
> };
>
> -#define METRIC_LEN 35
> +#define METRIC_LEN 38
>
> static void new_line_std(struct perf_stat_config *config __maybe_unused,
> void *ctx)
> --
> 2.38.1.431.g37b22c650d-goog
>
Powered by blists - more mailing lists