linux-kernel - Re: [PATCH 2/2] erofs: get correct count for unmapped range in fscache mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e288944b-559c-e184-96c4-370a80cbb9a9@kernel.org>
Date:   Tue, 8 Nov 2022 11:09:29 +0800
From:   Chao Yu <chao@...nel.org>
To:     Jingbo Xu <jefflexu@...ux.alibaba.com>, xiang@...nel.org,
        huyue2@...lpad.com, linux-erofs@...ts.ozlabs.org
Cc:     zhujia.zj@...edance.com, yinxin.x@...edance.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] erofs: get correct count for unmapped range in
 fscache mode

On 2022/11/4 13:40, Jingbo Xu wrote:
> For unmapped range, the returned map.m_llen is zero, and thus the
> calculated count is unexpected zero.
> 
> Prior to the refactoring introduced by commit 1ae9470c3e14 ("erofs:
> clean up .read_folio() and .readahead() in fscache mode"), only the
> readahead routine suffers from this. With the refactoring of making
> .read_folio() and .readahead() calling one common routine, both
> read_folio and readahead have this issue now.
> 
> Fix this by calculating count separately in unmapped condition.
> 
> Fixes: c665b394b9e8 ("erofs: implement fscache-based data readahead")
> Fixes: 1ae9470c3e14 ("erofs: clean up .read_folio() and .readahead() in fscache mode")
> Signed-off-by: Jingbo Xu <jefflexu@...ux.alibaba.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,