linux-kernel - Re: [PATCH] mm: fix compiler warning with make W=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221108061753.GA23955@hu-pkondeti-hyd.qualcomm.com>
Date:   Tue, 8 Nov 2022 11:47:53 +0530
From:   Pavan Kondeti <quic_pkondeti@...cinc.com>
To:     Charan Teja Kalla <quic_charante@...cinc.com>
CC:     <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, <vbabka@...e.cz>
Subject: Re: [PATCH] mm: fix compiler warning with make W=1

Hi Charan,

On Tue, Nov 08, 2022 at 10:46:22AM +0530, Charan Teja Kalla wrote:
> Fix the below compiler warnings reported with 'make W=1 mm/'.
> mm/page_ext.c:178: warning: Function parameter or member 'page_ext' not
> described in 'page_ext_put'.
> 
> Reported-by: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: Charan Teja Kalla <quic_charante@...cinc.com>
> ---
>  mm/page_ext.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_ext.c b/mm/page_ext.c
> index affe8024..ddf1968 100644
> --- a/mm/page_ext.c
> +++ b/mm/page_ext.c
> @@ -166,7 +166,7 @@ struct page_ext *page_ext_get(struct page *page)
>  
>  /**
>   * page_ext_put() - Working with page extended information is done.
> - * @page_ext - Page extended information received from page_ext_get().
> + * @page_ext: Page extended information received from page_ext_get().
>   *
>   * The page extended information of the page may not be valid after this
>   * function is called.
> 

Looks good to me. Your patch fixes the warning emitted earlier by

./scripts/kernel-doc -none mm/page_ext.c
mm/page_ext.c:178: warning: Function parameter or member 'page_ext' not described in 'page_ext_put'

one nit comment on the changelog summary

mm: fix compiler warning with make W=1

Can you make it more specific like "mm/page_exit: fix kernel doc warning in page_ext_put()"

Thanks,
Pavan