| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <01bf01d8f332$7c15fdc0$7441f940$@samsung.com>
Date: Tue, 8 Nov 2022 10:55:13 +0530
From: "Padmanabhan Rajanbabu" <p.rajanbabu@...sung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
"'Alim Akhtar'" <alim.akhtar@...sung.com>, <lgirdwood@...il.com>,
<broonie@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <s.nawrocki@...sung.com>,
<perex@...ex.cz>, <tiwai@...e.com>, <pankaj.dubey@...sung.com>,
<rcsekar@...sung.com>, <aswani.reddy@...sung.com>
Cc: <alsa-devel@...a-project.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>
Subject: RE: [PATCH 6/6] arm64: dts: fsd: Add sound card node for Tesla FSD
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
> Sent: 21 October 2022 06:24 PM
> To: Padmanabhan Rajanbabu <p.rajanbabu@...sung.com>; 'Alim Akhtar'
> <alim.akhtar@...sung.com>; lgirdwood@...il.com; broonie@...nel.org;
> robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> s.nawrocki@...sung.com; perex@...ex.cz; tiwai@...e.com;
> pankaj.dubey@...sung.com; rcsekar@...sung.com;
> aswani.reddy@...sung.com
> Cc: alsa-devel@...a-project.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-samsung-soc@...r.kernel.org
> Subject: Re: [PATCH 6/6] arm64: dts: fsd: Add sound card node for Tesla FSD
>
> On 21/10/2022 04:12, Padmanabhan Rajanbabu wrote:
> >
> >
> >> -----Original Message-----
> >> From: Alim Akhtar [mailto:alim.akhtar@...sung.com]
> >> Sent: 14 October 2022 06:59 PM
> >> To: 'Padmanabhan Rajanbabu' <p.rajanbabu@...sung.com>;
> >> lgirdwood@...il.com; broonie@...nel.org; robh+dt@...nel.org;
> >> krzysztof.kozlowski+dt@...aro.org; s.nawrocki@...sung.com;
> >> perex@...ex.cz; tiwai@...e.com; pankaj.dubey@...sung.com;
> >> rcsekar@...sung.com; aswani.reddy@...sung.com
> >> Cc: alsa-devel@...a-project.org; devicetree@...r.kernel.org; linux-
> >> kernel@...r.kernel.org; linux-samsung-soc@...r.kernel.org
> >> Subject: RE: [PATCH 6/6] arm64: dts: fsd: Add sound card node for
> >> Tesla FSD
> >>
> >>
> >>
> >>> -----Original Message-----
> >>> From: Padmanabhan Rajanbabu [mailto:p.rajanbabu@...sung.com]
> >>> Sent: Friday, October 14, 2022 3:52 PM
> >>> To: lgirdwood@...il.com; broonie@...nel.org; robh+dt@...nel.org;
> >>> krzysztof.kozlowski+dt@...aro.org; s.nawrocki@...sung.com;
> >>> perex@...ex.cz; tiwai@...e.com; pankaj.dubey@...sung.com;
> >>> alim.akhtar@...sung.com; rcsekar@...sung.com;
> >> aswani.reddy@...sung.com
> >>> Cc: alsa-devel@...a-project.org; devicetree@...r.kernel.org; linux-
> >>> kernel@...r.kernel.org; linux-samsung-soc@...r.kernel.org;
> >> Padmanabhan
> >>> Rajanbabu <p.rajanbabu@...sung.com>
> >>> Subject: [PATCH 6/6] arm64: dts: fsd: Add sound card node for Tesla
> >>> FSD
> >>>
> >>> Add device tree node support for sound card on Tesla FSD board
> >>>
> >>> Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@...sung.com>
> >>> ---
> >>> arch/arm64/boot/dts/tesla/fsd-evb.dts | 49
> >>> +++++++++++++++++++++++++++
> >>> arch/arm64/boot/dts/tesla/fsd.dtsi | 3 ++
> >>> 2 files changed, 52 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> >>> b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> >>> index c0a4509499ab..ecaa3c2e3045 100644
> >>> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> >>> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> >>> @@ -49,3 +49,52 @@
> >>> &tdm_1 {
> >>> status = "okay";
> >>> };
> >>> +
> >>> +&sound {
> >>> + compatible = "tesla,fsd-sndcard";
> >>> + status = "okay";
> >>> + model = "fsd-i2s";
> >>> + widgets =
> >>> + "Speaker", "MAIN SPK",
> >>> + "Microphone", "MAIN MIC";
> >>> +
> >>> + primary-dai-link-0 {
> >>> + link-name = "fsd-primary-0";
> >>> + dai-format = "i2s";
> >>> + tesla,bitclock-master = <&tdm_0>;
> >>> + tesla,frame-master = <&tdm_0>;
> >>> + cpu {
> >>> + sound-dai = <&tdm_0 0>;
> >>> + };
> >>> + };
> >>> +
> >>> + secondary-dai-link-0 {
> >>> + link-name = "fsd-secondary-0";
> >>> + dai-format = "i2s";
> >>> + tesla,bitclock-master = <&tdm_0>;
> >>> + tesla,frame-master = <&tdm_0>;
> >>> + cpu {
> >>> + sound-dai = <&tdm_0 1>;
> >>> + };
> >>> + };
> >>> +
> >>> + primary-dai-link-1 {
> >>> + link-name = "fsd-primary-1";
> >>> + dai-format = "i2s";
> >>> + tesla,bitclock-master = <&tdm_1>;
> >>> + tesla,frame-master = <&tdm_1>;
> >>> + cpu {
> >>> + sound-dai = <&tdm_1 0>;
> >>> + };
> >>> + };
> >>> +
> >>> + secondary-dai-link-1 {
> >>> + link-name = "fsd-secondary-1";
> >>> + dai-format = "i2s";
> >>> + tesla,bitclock-master = <&tdm_1>;
> >>> + tesla,frame-master = <&tdm_1>;
> >>> + cpu {
> >>> + sound-dai = <&tdm_1 1>;
> >>> + };
> >>> + };
> >>> +};
> >>> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> b/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> index 5decad45a1b6..fc8931f830a7 100644
> >>> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> @@ -847,6 +847,9 @@
> >>> status = "disabled";
> >>> };
> >>>
> >>> + sound: sound {
> >>> + };
> >>> +
> >> Why to have an empty node in dtsi?
> > This is required as every node we use in dts should have the same
> > declared in
>
> I see no reason why this is required.
>
> > dtsi. Sound nodes in most of the platform is only declared (dummy
> > node) in dtsi and defining only in dts. Thus we are following the same.
>
> Can you point me to Samsung platform doing this?
>
> Keep the code consistent with Exynos style.
Okay, will add the sound node in accordance with Exynos style
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists