linux-kernel - [PATCH v1 2/2] at_hdmac: return actual status when txstatus parameter is NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221108074938.48853-2-andriy.shevchenko@linux.intel.com>
Date:   Tue,  8 Nov 2022 09:49:38 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Vinod Koul <vkoul@...nel.org>,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: [PATCH v1 2/2] at_hdmac: return actual status when txstatus parameter is NULL

There is no point to return DMA_ERROR if txstatus parameter is NULL. It's a
valid case and should be handled correspondingly.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
---
 drivers/dma/at_hdmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index a9d8dd990d6e..4035d5438530 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -1679,7 +1679,7 @@ atc_tx_status(struct dma_chan *chan,
 	if (!txstate) {
 		if (test_bit(ATC_IS_PAUSED, &atchan->status))
 			return DMA_PAUSED;
-		return DMA_ERROR;
+		return dma_status;
 	}
 
 	spin_lock_irqsave(&atchan->vc.lock, flags);
-- 
2.35.1