linux-kernel - Re: [PATCH RFC v3] random: implement getrandom() in vDSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v8np978s.ffs@tglx>
Date:   Tue, 08 Nov 2022 09:32:19 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "Jason A. Donenfeld" <Jason@...c4.com>,
        linux-kernel@...r.kernel.org
Cc:     "Jason A. Donenfeld" <Jason@...c4.com>,
        linux-crypto@...r.kernel.org, x86@...nel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Adhemerval Zanella Netto <adhemerval.zanella@...aro.org>,
        Carlos O'Donell <carlos@...hat.com>
Subject: Re: [PATCH RFC v3] random: implement getrandom() in vDSO

On Fri, Sep 16 2022 at 13:59, Jason A. Donenfeld wrote:
> ---
>  MAINTAINERS                            |   2 +
>  arch/x86/entry/syscalls/syscall_32.tbl |   1 +
>  arch/x86/entry/syscalls/syscall_64.tbl |   1 +
>  arch/x86/entry/vdso/Makefile           |   3 +-
>  arch/x86/entry/vdso/vdso.lds.S         |   2 +
>  arch/x86/entry/vdso/vgetrandom.c       |  16 ++++
>  arch/x86/include/asm/vdso/getrandom.h  |  37 ++++++++
>  arch/x86/include/asm/vvar.h            |  16 ++++
>  drivers/char/random.c                  |  64 ++++++++++++++
>  include/vdso/datapage.h                |   6 ++
>  lib/crypto/chacha.c                    |   4 +
>  lib/vdso/getrandom.c                   | 117 +++++++++++++++++++++++++
>  lib/vdso/getrandom.h                   |  25 ++++++
>  13 files changed, 293 insertions(+), 1 deletion(-)
>  create mode 100644 arch/x86/entry/vdso/vgetrandom.c
>  create mode 100644 arch/x86/include/asm/vdso/getrandom.h
>  create mode 100644 lib/vdso/getrandom.c
>  create mode 100644 lib/vdso/getrandom.h

This is not how it works. Please split this apart into reviewable bits
and pieces:

1) Add the new syscall
2) Add the vdso infrastructure
3) Wire it up on x86

Thanks,

        tglx