linux-kernel - Re: [PATCH v2 1/2] arm64: dts: qcom: Fully describe fingerprint node on Herobrine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=UJEkNcWWFExQsCD5SXvH_YvoK_K6mtFB0_ojDSNLP8Zg@mail.gmail.com>
Date:   Mon, 7 Nov 2022 17:22:47 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        linux-arm-msm@...r.kernel.org,
        Matthias Kaehlcke <mka@...omium.org>,
        Alexandru M Stan <amstan@...omium.org>
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: Fully describe fingerprint node
 on Herobrine

Hi,

On Mon, Nov 7, 2022 at 11:15 AM Stephen Boyd <swboyd@...omium.org> wrote:
>
> Update the fingerprint node on Herobrine to match the fingerprint DT
> binding. This will allow us to drive the reset and boot gpios from the
> driver when it is re-attached after flashing. We'll also be able to boot
> the fingerprint processor if the BIOS isn't doing it for us.
>
> Cc: Douglas Anderson <dianders@...omium.org>
> Cc: Matthias Kaehlcke <mka@...omium.org>
> Cc: Alexandru M Stan <amstan@...omium.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

>From Bjorn's recent comment [1], I think your subject needs modification to:

   arm64: dts: qcom: sc7280: Fully describe fingerprint node on Herobrine

Other than that this seems fine and is a better description of hardware, so:

Reviewed-by: Douglas Anderson <dianders@...omium.org>

I guess we're still leaving gpio77 alone (AKA not describing it in the
fingerprint regulator)?

[1] https://lore.kernel.org/r/20221017224853.stuy5qeqxjxntob4@builder.lan/