linux-kernel - Re: [PATCH v1 5/7] ARM: dts: hpe: Add UDC nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd9ee5df-0b9d-59c1-92c6-4874312aae1c@linaro.org>
Date:   Tue, 8 Nov 2022 12:28:24 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     richard.yu@....com, verdun@....com, nick.hawkins@....com,
        gregkh@...uxfoundation.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux@...linux.org.uk,
        balbi@...nel.org, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v1 5/7] ARM: dts: hpe: Add UDC nodes

On 03/11/2022 17:06, richard.yu@....com wrote:
> From: Richard Yu <richard.yu@....com>
> 
> Add support for the USB drivers on HPE GXP SoC.
> 
> Signed-off-by: Richard Yu <richard.yu@....com>
> ---
>  arch/arm/boot/dts/hpe-gxp.dtsi | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/hpe-gxp.dtsi b/arch/arm/boot/dts/hpe-gxp.dtsi
> index cf735b3c4f35..60f2d3b15d90 100644
> --- a/arch/arm/boot/dts/hpe-gxp.dtsi
> +++ b/arch/arm/boot/dts/hpe-gxp.dtsi
> @@ -59,6 +59,36 @@
>  			ranges = <0x0 0xc0000000 0x30000000>;
>  			dma-ranges;
>  
> +			vuhc0: vuhc@...00000 {
> +				compatible = "hpe,gxp-vuhc", "syscon";
> +				reg = <0x80400000 0x80>;
> +			};
> +
> +			udc_system_controller: system-controller@...00800 {
> +				compatible = "hpe,gxp-udcg", "syscon";
> +				reg = <0x80400800 0x200>;
> +			};
> +
> +			gadget0: udc@...01000 {
> +				compatible = "hpe,gxp-udc";
> +				reg = <0x80401000 0x1000>;
> +				interrupts = <13>;
> +				interrupt-parent = <&vic1>;
> +				vdevnum = <0>;
> +				fepnum = <7>;
> +				hpe,syscon-phandle = <&udc_system_controller>;
> +			};
> +
> +			gadget1: udc@...02000 {
> +				compatible = "hpe,gxp-udc";
> +				reg = <0x80402000 0x1000>;
> +				interrupts = <13>;
> +				interrupt-parent = <&vic1>;
> +				vdevnum = <1>;
> +				fepnum = <7>;
> +				hpe,syscon-phandle = <&udc_system_controller>;

Based on your bindings explanation, UDC should be rather the device
with multiple children representing actual devices.

Best regards,
Krzysztof