linux-kernel - Re: [PATCH v1 2/2] at_hdmac: return actual status when txstatus parameter is NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Nov 2022 11:51:20 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <andriy.shevchenko@...ux.intel.com>, <vkoul@...nel.org>,
        <Nicolas.Ferre@...rochip.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <Ludovic.Desroches@...rochip.com>
Subject: Re: [PATCH v1 2/2] at_hdmac: return actual status when txstatus
 parameter is NULL

On 11/8/22 09:49, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> There is no point to return DMA_ERROR if txstatus parameter is NULL. It's a
> valid case and should be handled correspondingly.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/dma/at_hdmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index a9d8dd990d6e..4035d5438530 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -1679,7 +1679,7 @@ atc_tx_status(struct dma_chan *chan,
>         if (!txstate) {
>                 if (test_bit(ATC_IS_PAUSED, &atchan->status))
>                         return DMA_PAUSED;
> -               return DMA_ERROR;
> +               return dma_status;

oh, I see you do it here, please squash this patch to the previous one,
you introduced DMA_ERROR in the previous patch.

>         }
> 
>         spin_lock_irqsave(&atchan->vc.lock, flags);
> --
> 2.35.1
> 

-- 
Cheers,
ta