linux-kernel - Re: [PATCH v2] wifi: ath10k: Add WLAN firmware image version info into smem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a07cb525-b814-241b-db72-840f5c17e785@quicinc.com>
Date:   Tue, 8 Nov 2022 17:34:43 +0530
From:   "Youghandhar Chintala (Temp)" <quic_youghand@...cinc.com>
To:     Kalle Valo <kvalo@...nel.org>
CC:     <ath11k@...ts.infradead.org>, <linux-wireless@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_mpubbise@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] wifi: ath10k: Add WLAN firmware image version info
 into smem


On 11/8/2022 4:00 PM, Kalle Valo wrote:
> Youghandhar Chintala <quic_youghand@...cinc.com> wrote:
>
>> In a SoC based solution, it would be useful to know the versions of the
>> various binary firmware blobs the system is running on. On a QCOM based
>> SoC, this info can be obtained from socinfo debugfs infrastructure. For
>> this to work, respective subsystem drivers have to export the firmware
>> version information to an SMEM based version information table.
>>
>> Having firmware version information at one place will help quickly
>> figure out the firmware versions of various subsystems on the device
>> instead of going through builds/logs in an event of a system crash.
>>
>> Fill WLAN firmware version information in SMEM version table to be
>> printed as part of socinfo debugfs infrastructure on a Qualcomm based
>> SoC.
>>
>> This change is applicable only for WCN399X targets.
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>>
>> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2.c10-00754-QCAHLSWMTPL-1
>>
>> Signed-off-by: Youghandhar Chintala <quic_youghand@...cinc.com>
>> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>
> This doesn't compile unless QCOM_SMEM is enabled in Kconfig. So should we add
> "select QCOM_SMEM" in Kconfig for ATH10K_SNOC?

Yes Kalle. Thank you.

Regards,

Youghandhar