linux-kernel - Re: [PATCH] ina3221: add support for summation channel control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Nov 2022 14:10:19 +0100
From:   Thierry Reding <treding@...dia.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Ninad Malwade <nmalwade@...dia.com>, jonathanh@...dia.com,
        linux@...ck-us.net, jdelvare@...e.com, nicolinc@...dia.com,
        rkasirajan@...dia.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] ina3221: add support for summation channel control

On Tue, Nov 08, 2022 at 02:02:54PM +0100, Krzysztof Kozlowski wrote:
> On 08/11/2022 05:52, Ninad Malwade wrote:
> > Add support to initialize summation channel control via kernel device
> > tree property "summation-bypass". The channel which has this property
> > is excluded from channel summation.
> > 
> > Signed-off-by: Ninad Malwade <nmalwade@...dia.com>
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC.  It might happen, that command when run on an older
> kernel, gives you outdated entries.  Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> You skipped not only one, but all DT maintainers and mailing lists...
> 
> > ---
> >  .../devicetree/bindings/hwmon/ina3221.txt          |  2 ++
> >  drivers/hwmon/ina3221.c                            | 14 ++++++++++++--
> 
> DT bindings and driver changes are separate patches.
> 
> 
> >  2 files changed, 14 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/ina3221.txt b/Documentation/devicetree/bindings/hwmon/ina3221.txt
> > index fa63b6171407..c6e8e6aafcce 100644
> > --- a/Documentation/devicetree/bindings/hwmon/ina3221.txt
> > +++ b/Documentation/devicetree/bindings/hwmon/ina3221.txt
> > @@ -29,6 +29,7 @@ Texas Instruments INA3221 Device Tree Bindings
> >    Optional properties:
> >    - label: Name of the input source
> >    - shunt-resistor-micro-ohms: Shunt resistor value in micro-Ohm
> > +  - summation-bypass: exclude from channel summation.
> 
> Convert to DT schema first.

I do have a local patch to convert, I'll attach it here so that Ninad
can include it in this series.

Thierry

View attachment "0001-dt-bindings-hwmon-ina3221-Convert-to-json-schema.patch" of type "text/plain" (6081 bytes)

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)