linux-kernel - Re: [PATCH v5 4/4] dt-bindings: soundwire: Convert text bindings to DT Schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Nov 2022 14:49:58 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>,
        vkoul@...nel.org, agross@...nel.org, andersson@...nel.org,
        robh+dt@...nel.org, broonie@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_rohkumar@...cinc.com, srinivas.kandagatla@...aro.org,
        dianders@...omium.org, swboyd@...omium.org, judyhsiao@...omium.org,
        alsa-devel@...a-project.org, quic_rjendra@...cinc.com,
        konrad.dybcio@...ainline.org, mka@...omium.org
Cc:     Ratna Deepthi Kudaravalli <quic_rkudarav@...cinc.com>
Subject: Re: [PATCH v5 4/4] dt-bindings: soundwire: Convert text bindings to
 DT Schema

On 08/11/2022 14:29, Srinivasa Rao Mandadapu wrote:
>>> +  qcom,ports-block-pack-mode:
>>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>>> +    description: Indicate the block packing mode.
>>> +                 0 to indicate Blocks are per Channel
>>> +                 1 to indicate Blocks are per Port.
>>> +                 Out ports followed by In ports.
>>> +                 Value of 0xFF indicates that this option is not implemented
>>> +                 or applicable for the respective data port.
>>> +                 More info in MIPI Alliance SoundWire 1.0 Specifications.
>>> +    minItems: 3
>>> +    maxItems: 8
>>> +
>>> +  qcom,ports-hstart:
>>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>>> +    description: Identifying lowerst numbered coloum in
>>> +                 SoundWire Frame, i.e. left edge of the Transport sub-frame
>>> +                 for each port. Values between 0 and 15 are valid.
>> minimum: 0
>> maximum: 15
>> and drop that one sentence.
>>
>> The same in other places.
> 
> As below mentioned it will also have 0xFF value. I think we can't 
> restrict with minimum and maximum values.
> 
> Please suggest if my understanding is wrong.

Then (and it is actually an array):
minItems: 3
maxItems: 5
items:
  oneOf:
    - minimum: 0
      maximum: 15
    - const: 0xff

> 
>>
>>> +                 Out ports followed by In ports.
>>> +                 Value of 0xFF indicates that this option is not implemented
>>> +                 or applicable for the respective data port.
>>> +                 More info in MIPI Alliance SoundWire 1.0 Specifications.
>>> +    minItems: 3
>>> +    maxItems: 5
>>> +
>>> +  qcom,ports-hstop:
>>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>>> +    description: Identifying highest numbered coloum in
>>> +                 SoundWire Frame, i.e. the right edge of the Transport
>>> +                 sub-frame for each port. Values between 0 and 15 are valid.
>>> +                 Out ports followed by In ports.
>>> +                 Value of 0xFF indicates that this option is not implemented
>>> +                 or applicable for the respective data port.
>>> +                 More info in MIPI Alliance SoundWire 1.0 Specifications.
>>> +    minItems: 3
>>> +    maxItems: 5
>>> +
>>> +  qcom,ports-block-group-count:
>>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>>> +    description: In range 1 to 4 to indicate how many sample
>>> +                 intervals are combined into a payload.
>>> +                 Out ports followed by In ports.
>>> +                 Value of 0xFF indicates that this option is not implemented
>>> +                 or applicable for the respective data port.
>>> +                 More info in MIPI Alliance SoundWire 1.0 Specifications.
>>> +    minItems: 3
>>> +    maxItems: 5
>>> +
>>> +  label:
>>> +    maxItems: 1
>>> +
>>> +patternProperties:
>>> +  "^.*@[0-9a-f],[0-9a-f]$":
>>> +    type: object
>>> +    description: Child nodes for a standalone audio codec or speaker amplifier IC.
>>> +                 It has RX and TX Soundwire slave devices.
>> s/slave/secondary/
>>
>> This is some odd indentation. Please use standard, like example-schema
>> is showing, so:
>>
>>      description:
>>        Child nodes for a standalone audio codec or speaker amplifier IC.
>>        RX and TX Soundwire slave devices.
>>
>> It looks you used such pattern in other places here - they should also
>> be corrected.
> Okay. Will change accordingly.
>>
>>> +    properties:
>>> +      compatible:
>>> +        pattern: "^sdw[0-9a-f]{1}[0-9a-f]{4}[0-9a-f]{4}[0-9a-f]{2}$"
>>> +
>>
>> Best regards,
>> Krzysztof
>>

Best regards,
Krzysztof