linux-kernel - Re: [PATCH v5 1/4] genirq: Fix the return type of kstat_cpu_irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cc8bbff-a195-01c7-d992-5dffa0ebe1b8@quicinc.com>
Date:   Tue, 8 Nov 2022 19:52:12 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Zhen Lei <thunder.leizhen@...wei.com>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Frederic Weisbecker <frederic@...nel.org>,
        "Neeraj Upadhyay" <quic_neeraju@...cinc.com>,
        Josh Triplett <josh@...htriplett.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Joel Fernandes <joel@...lfernandes.org>, <rcu@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     Robert Elliott <elliott@....com>
Subject: Re: [PATCH v5 1/4] genirq: Fix the return type of
 kstat_cpu_irqs_sum()

Hi,

On 11/4/2022 7:41 PM, Zhen Lei wrote:
> The type of member irqs_sum is unsigned long, so kstat_cpu_irqs_sum()
> should also return unsigned long. Otherwise, the value maybe truncated.
> 
> Fixes: f2c66cd8eedd ("/proc/stat: scalability of irq num per cpu")
> Reported-by: Elliott, Robert (Servers) <elliott@....com>
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@...cinc.com>

-Mukesh

> ---
>   include/linux/kernel_stat.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/kernel_stat.h b/include/linux/kernel_stat.h
> index ddb5a358fd829f4..90e2fdc17d79ff8 100644
> --- a/include/linux/kernel_stat.h
> +++ b/include/linux/kernel_stat.h
> @@ -75,7 +75,7 @@ extern unsigned int kstat_irqs_usr(unsigned int irq);
>   /*
>    * Number of interrupts per cpu, since bootup
>    */
> -static inline unsigned int kstat_cpu_irqs_sum(unsigned int cpu)
> +static inline unsigned long kstat_cpu_irqs_sum(unsigned int cpu)
>   {
>   	return kstat_cpu(cpu).irqs_sum;
>   }