linux-kernel - Re: [PATCH v2 5/5] arm64: dts: uniphier: Add NX1 SoC and boards support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df21cfca-67ed-0c78-7f1e-13e321edabe1@socionext.com>
Date:   Tue, 8 Nov 2022 23:30:24 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        Masami Hiramatsu <mhiramat@...nel.org>
Cc:     soc@...nel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] arm64: dts: uniphier: Add NX1 SoC and boards
 support

Hi Krzysztof,

On 2022/11/08 20:13, Krzysztof Kozlowski wrote:
> On 07/11/2022 11:34, Kunihiko Hayashi wrote:
>> Initial version of devicetree sources for NX1 SoC and boards.
>>
>> NX1 SoC belongs to the UniPhier armv8 architecture platform, and is
>> designed for IoT and AI/ML application fields.
>>
> 
>> +
>> +		soc_glue: syscon@...00000 {
>> +			compatible = "socionext,uniphier-nx1-soc-glue",
>> +				     "simple-mfd", "syscon";
>> +			reg = <0x1f800000 0x2000>;
>> +
>> +			pinctrl: pinctrl {
>> +				compatible = "socionext,uniphier-nx1-pinctrl";
> 
> So instead of documenting the hardware precisily, you have one big bag
> for everything under simple-mfd. This is not how the SoC should be
> described in DTS.

Sorry I don't understand. This is inherited from the previous descriptions,
but is there some example to express DTS correctly about that?

> 
>> +			};
>> +		};
>> +
>> +		soc-glue@...00000 {
>> +			compatible = "simple-mfd";
> 
> No, it is not allowed on its own. You need a specific compatible and
> bindings describing its children.

I saw the definition of "simple-mfd" itself is only in mfd/mfd.txt.

Currently there are only efuse devices as children, and this space means
nothing. I think it had better define the devices directly.

Thank you,
---
Best Regards
Kunihiko Hayashi