[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221108153820.fp5du7p7zr7pc7cs@tarta.nabijaczleweli.xyz>
Date: Tue, 8 Nov 2022 16:38:20 +0100
From: наб <nabijaczleweli@...ijaczleweli.xyz>
To: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: Jonathan Corbet <corbet@....net>,
Federico Vaga <federico.vaga@...a.pv.it>,
Alex Shi <alexs@...nel.org>,
Yanteng Si <siyanteng@...ngson.cn>,
Hu Haowen <src.res@...il.cn>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-doc-tw-discuss@...ts.sourceforge.net,
linux-mips@...r.kernel.org
Subject: Re: [PATCH v2 07/15] MIPS: IP27: clean out sn/nmi.h
On Fri, Nov 04, 2022 at 03:50:02PM +0100, Thomas Bogendoerfer wrote:
> On Wed, Nov 02, 2022 at 12:05:30AM +0100, Ahelenia Ziemiańska wrote:
> > The only user is arch/mips/sgi-ip27/ip27-nmi.c; this file was imported
> > wholesale in 2.3.99pre9-1, and received only whitespace updates since
> > then.
> >
> > NMI_MAGIC isn't a magic number; it's unclear if it's actually used by
> > the firmware in some capacity or if it's a holdover from copying the SGI
> > code, but in the former case it's API and in the latter it's dead cruft.
>
> it's used by firmware and Linux code to register the NMI exception
> handler.
Great, I'll put that in the message.
> Please leave arch/mips/include/asm/sn/nmi.h untouched as
> it's documents firmware NMI handler usage (even when we don't use it, yet).
"Yet".
This file appeared in 2.3.99pre9-1, and hasn't changed since.
I removed hard-coded assembly struct offsets, which we'll never use,
because we /haven't/ used them, and this part is implemented in C.
This file's my age, and these parts have been dead for just as long.
Yet.
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists