linux-kernel - Re: [PATCH net-next 1/1] net: phy: dp83867: add TI PHY loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2p5Q1D1/HSW+lrb@lunn.ch>
Date:   Tue, 8 Nov 2022 16:44:03 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Sit Wei Hong <michael.wei.hong.sit@...el.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Tan Tee Min <tee.min.tan@...el.com>,
        Looi Hong Aun <hong.aun.looi@...el.com>,
        Voon Weifeng <weifeng.voon@...el.com>,
        Zulkifli Muhammad Husaini <muhammad.husaini.zulkifli@...el.com>,
        Gan Yi Fang <yi.fang.gan@...el.com>
Subject: Re: [PATCH net-next 1/1] net: phy: dp83867: add TI PHY loopback

On Tue, Nov 08, 2022 at 06:15:27PM +0800, Michael Sit Wei Hong wrote:
> From: Tan Tee Min <tee.min.tan@...ux.intel.com>
> 
> The existing genphy_loopback() is not working for TI DP83867 PHY as it
> will disable autoneg support while another side is still enabling autoneg.
> This is causing the link is not established and results in timeout error
> in genphy_loopback() function.
> 
> Thus, based on TI PHY datasheet, introduce a TI PHY loopback function by
> just configuring BMCR_LOOPBACK(Bit-9) in MII_BMCR register (0x0).
> 
> Tested working on TI DP83867 PHY for all speeds (10/100/1000Mbps).
> 
> Signed-off-by: Tan Tee Min <tee.min.tan@...ux.intel.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew