linux-kernel - Re: [PATCH 1/3] drivers/perf: hisi: Fix some event id for hisi-pcie-pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221109165952.000053f3@Huawei.com>
Date:   Wed, 9 Nov 2022 16:59:52 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Yicong Yang <yangyicong@...wei.com>
CC:     Shaokun Zhang <zhangshaokun@...ilicon.com>, <liuqi6124@...il.com>,
        Jonathan Corbet <corbet@....net>,
        Will Deacon <will@...nel.org>,
        "Mark Rutland" <mark.rutland@....com>,
        John Garry <john.garry@...wei.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-doc@...r.kernel.org>, <linuxarm@...wei.com>,
        <f.fangjian@...wei.com>, <prime.zeng@...wei.com>
Subject: Re: [PATCH 1/3] drivers/perf: hisi: Fix some event id for
 hisi-pcie-pmu

On Tue, 25 Oct 2022 19:32:40 +0800
Yicong Yang <yangyicong@...wei.com> wrote:

> From: Yicong Yang <yangyicong@...ilicon.com>
> 
> Some event id of hisi-pcie-pmu is incorrect, fix them.
> 
> Fixes: 8404b0fbc7fb ("drivers/perf: hisi: Add driver for HiSilicon PCIe PMU")
> Signed-off-by: Yicong Yang <yangyicong@...ilicon.com>
FWIW given these are magic value updates.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>


> ---
>  drivers/perf/hisilicon/hisi_pcie_pmu.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/perf/hisilicon/hisi_pcie_pmu.c b/drivers/perf/hisilicon/hisi_pcie_pmu.c
> index 21771708597d..071e63d9a9ac 100644
> --- a/drivers/perf/hisilicon/hisi_pcie_pmu.c
> +++ b/drivers/perf/hisilicon/hisi_pcie_pmu.c
> @@ -693,10 +693,10 @@ static struct attribute *hisi_pcie_pmu_events_attr[] = {
>  	HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_cnt, 0x10210),
>  	HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_latency, 0x0011),
>  	HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_cnt, 0x10011),
> -	HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_flux, 0x1005),
> -	HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_time, 0x11005),
> -	HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_flux, 0x2004),
> -	HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_time, 0x12004),
> +	HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_flux, 0x0804),
> +	HISI_PCIE_PMU_EVENT_ATTR(rx_mrd_time, 0x10804),
> +	HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_flux, 0x0405),
> +	HISI_PCIE_PMU_EVENT_ATTR(tx_mrd_time, 0x10405),
>  	NULL
>  };
>