linux-kernel - [PATCH] scripts: dev-needs.sh: Enforce bash usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 09 Nov 2022 17:03:59 +0000
From:   Steffen Kothe <steffen.kothe@...the.de>
To:     saravanak@...gle.com
Cc:     linux-kernel@...r.kernel.org,
        Steffen Kothe <steffen.kothe@...the.de>
Subject: [PATCH] scripts: dev-needs.sh: Enforce bash usage

Calling the script from a system which does not invoke bash
by default causes a return with a syntax error like:

	./dev-needs.sh: 6: Syntax error: "(" unexpected

/bin/sh invokes on most distributions a symbolic link to a
default shell like dash (Debian) or bash (Ubuntu).

Since the script depends on bash syntax, enforce the same by
default to prevent syntax errors caused by wrong shell type usage.

Signed-off-by: Steffen Kothe <steffen.kothe@...the.de>
---
 scripts/dev-needs.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/dev-needs.sh b/scripts/dev-needs.sh
index 454cc304fb448..46537859727bc 100755
--- a/scripts/dev-needs.sh
+++ b/scripts/dev-needs.sh
@@ -1,4 +1,4 @@
-#! /bin/sh
+#! /bin/bash
 # SPDX-License-Identifier: GPL-2.0
 # Copyright (c) 2020, Google LLC. All rights reserved.
 # Author: Saravana Kannan <saravanak@...gle.com>
--
2.30.2