linux-kernel - [PATCH] drivers: clk: clk-conf.c: Move err to warn msg for clk re-parenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20221109184253.40531-1-steffen.kothe@skothe.de>
Date:   Wed, 09 Nov 2022 18:43:58 +0000
From:   Steffen Kothe <steffen.kothe@...the.de>
To:     mturquette@...libre.com, sboyd@...nel.org
Cc:     linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        Steffen Kothe <steffen.kothe@...the.de>
Subject: [PATCH] drivers: clk: clk-conf.c: Move err to warn msg for clk re-parenting

Failed clock re-parenting does not necessarily imply critical errors
since systems can initialize clocks which prohibit it by default and
purpose.

The error does not even imply any required handling which should treat
as a warning then.

Signed-off-by: Steffen Kothe <steffen.kothe@...the.de>
---
 drivers/clk/clk-conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
index 2ef819606c417..d83591dc22356 100644
--- a/drivers/clk/clk-conf.c
+++ b/drivers/clk/clk-conf.c
@@ -62,7 +62,7 @@ static int __set_clk_parents(struct device_node *node, bool clk_supplier)

 		rc = clk_set_parent(clk, pclk);
 		if (rc < 0)
-			pr_err("clk: failed to reparent %s to %s: %d\n",
+			pr_warn("clk: failed to reparent %s to %s: %d\n",
 			       __clk_get_name(clk), __clk_get_name(pclk), rc);
 		clk_put(clk);
 		clk_put(pclk);
--
2.30.2