linux-kernel - Re: [PATCH v2] drm/amd/display: only fill dirty rectangles when PSR is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3956fafe-b6db-a1fe-78c4-24f364e37cfb@amd.com>
Date:   Wed, 9 Nov 2022 14:25:52 -0500
From:   Leo Li <sunpeng.li@....com>
To:     Hamza Mahfooz <hamza.mahfooz@....com>,
        amd-gfx@...ts.freedesktop.org
Cc:     Harry Wentland <harry.wentland@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
        Roman Li <roman.li@....com>, Fangzhi Zuo <Jerry.Zuo@....com>,
        Aurabindo Pillai <aurabindo.pillai@....com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/amd/display: only fill dirty rectangles when PSR
 is enabled



On 11/9/22 13:20, Hamza Mahfooz wrote:
> Currently, we are calling fill_dc_dirty_rects() even if PSR isn't
> supported by the relevant link in amdgpu_dm_commit_planes(), this is
> undesirable especially because when drm.debug is enabled we are printing
> messages in fill_dc_dirty_rects() that are only useful for debugging PSR
> (and confusing otherwise). So, we can instead limit the filling of dirty
> rectangles to only when PSR is enabled.
> 
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@....com>

Reviewed-by: Leo Li <sunpeng.li@....com>
Thanks

> ---
> v2: give a more concrete reason.
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 66eb16fbe09f..956a6e494709 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -7697,9 +7697,10 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_state *state,
>   		bundle->surface_updates[planes_count].plane_info =
>   			&bundle->plane_infos[planes_count];
>   
> -		fill_dc_dirty_rects(plane, old_plane_state, new_plane_state,
> -				    new_crtc_state,
> -				    &bundle->flip_addrs[planes_count]);
> +		if (acrtc_state->stream->link->psr_settings.psr_feature_enabled)
> +			fill_dc_dirty_rects(plane, old_plane_state,
> +					    new_plane_state, new_crtc_state,
> +					    &bundle->flip_addrs[planes_count]);
>   
>   		/*
>   		 * Only allow immediate flips for fast updates that don't