linux-kernel - Re: [PATCH] dt-bindings: pinctrl: qcom,msm8976: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221109204810.fyestfmom7nzgqt2@SoMainline.org>
Date:   Wed, 9 Nov 2022 21:48:10 +0100
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: qcom,msm8976: convert to dtschema

On 2022-11-09 12:33:37, Marijn Suijten wrote:
> On 2022-11-08 15:09:09, Krzysztof Kozlowski wrote:
> > Convert Qualcomm MSM8976 pin controller bindings to DT schema.  Keep the
> > parsing of pin configuration subnodes consistent with other Qualcomm
> > schemas (children named with '-state' suffix, their children with
> > '-pins').
> > 
> > Changes during conversion: update the list of non-mux pins (like sdc1)
> > to match Linux driver.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Thanks for sending this right as we are upstreaming MSM8976!  With one
> question and one nit below:
> 
> Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>

I retract my review on this patch, see below.

> > [..]
> > +        items:
> > +          oneOf:
> > +            - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-3][0-9]|14[0-4])$"
> > +            - enum: [ qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1, qdsd_data2,
> > +                      qdsd_data3 sdc1_clk, sdc1_cmd, sdc1_data, sdc1_rclk,

Missing a comma between 'qdsd_data3' and 'sdc1_clk', making the bindings
checker treat this as a single string 'qdsd_data3 sdc1_clk'.

- Marijn