linux-kernel - RE: [PATCH 2/3] media: s5p-mfc:Add variant data for MFC v7 hardware for Exynos 3250 SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Nov 2022 09:32:25 +0530
From:   "Aakarsh Jain" <aakarsh.jain@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        "'Marek Szyprowski'" <m.szyprowski@...sung.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Cc:     <andrzej.hajda@...el.com>, <mchehab@...nel.org>,
        <hverkuil-cisco@...all.nl>, <ezequiel@...guardiasur.com.ar>,
        <jernej.skrabec@...il.com>, <benjamin.gaignard@...labora.com>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <stanimir.varbanov@...aro.org>, <dillon.minfei@...il.com>,
        <david.plowman@...pberrypi.com>, <mark.rutland@....com>,
        <robh+dt@...nel.org>, <krzk+dt@...nel.org>, <andi@...zian.org>,
        <alim.akhtar@...sung.com>, <aswani.reddy@...sung.com>,
        <pankaj.dubey@...sung.com>, <smitha.t@...sung.com>
Subject: RE: [PATCH 2/3] media: s5p-mfc:Add variant data for MFC v7 hardware
 for Exynos 3250 SOC



> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...aro.org]
> Sent: 03 November 2022 18:16
> To: Marek Szyprowski <m.szyprowski@...sung.com>; Aakarsh Jain
> <aakarsh.jain@...sung.com>; linux-arm-kernel@...ts.infradead.org; linux-
> media@...r.kernel.org; linux-kernel@...r.kernel.org;
> devicetree@...r.kernel.org
> Cc: andrzej.hajda@...el.com; mchehab@...nel.org; hverkuil-cisco@...all.nl;
> ezequiel@...guardiasur.com.ar; jernej.skrabec@...il.com;
> benjamin.gaignard@...labora.com; krzysztof.kozlowski+dt@...aro.org;
> stanimir.varbanov@...aro.org; dillon.minfei@...il.com;
> david.plowman@...pberrypi.com; mark.rutland@....com;
> robh+dt@...nel.org; krzk+dt@...nel.org; andi@...zian.org;
> alim.akhtar@...sung.com; aswani.reddy@...sung.com;
> pankaj.dubey@...sung.com; smitha.t@...sung.com
> Subject: Re: [PATCH 2/3] media: s5p-mfc:Add variant data for MFC v7
> hardware for Exynos 3250 SOC
> 
> On 03/11/2022 08:44, Marek Szyprowski wrote:
> > On 03.11.2022 13:35, Krzysztof Kozlowski wrote:
> >> On 02/11/2022 09:06, Aakarsh Jain wrote:
> >>> commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for
> >> Please run scripts/checkpatch.pl and fix reported warnings.
> >>
As I didn't see any checkpatch warnings from the above commit message.
Anyway I fixed all checkpatch warnings from drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c and posted 3 patches for the same.
https://patchwork.kernel.org/project/linux-media/patch/20221109035348.69026-1-aakarsh.jain@samsung.com/

> >>> Exynos3250 and used the same compatible string as used by
> >>> Exynos5240 but both the IPs are a bit different in terms of IP
> >>> clock.
> >>> Lets add variant driver data based on the new compatible string
> >>> "samsung,exynos3250-mfc" for Exynos3250 SoC.
> >> Aren't you just missing the clock on Exynos3250?
> >
> > Nope, the Exynos3250 variant indeed has only one clock and the driver
> > code simply ignored the -ENOENT error while getting the clocks, see
> > the code in drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c, so it
> > worked fine even without it.
> >
> > IMHO it is a good idea to clean this up.
> 
> OK, then please make the new compatible followed by old.
> 
> Best regards,
> Krzysztof


Thanks for the review.