linux-kernel - Re: [PATCH linux-next] selftests/vm: calculate variables in correct order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Nov 2022 16:31:24 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Joel Savitz <jsavitz@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        David Hildenbrand <dhildenb@...hat.com>,
        Nico Pache <npache@...hat.com>, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH linux-next] selftests/vm: calculate variables in correct
 order

On Fri, 28 Oct 2022 09:26:40 -0400 Joel Savitz <jsavitz@...hat.com> wrote:

> commit b5ba705c2608 ("selftests/vm: enable running select groups of tests")
> unintentionally reversed the ordering of some of the lines of
> run_vmtests.sh that calculate values based on system configuration.
> Importantly, $hpgsize_MB is determined from $hpgsize_KB, but this later
> value is not read from /proc/meminfo until later, causing userfaultfd
> tests to incorrectly fail since $half_ufd_size_MB will always be 0.
> 
> Switch these statements around into proper order to fix the invocation
> of the userfaultfd tests that use $half_ufd_size_MB.

Does this fix address the failure in
https://lkml.kernel.org/r/202211021026.61b267d1-yujie.liu@intel.com?

Thanks.