linux-kernel - [PATCH v1 0/2] rtc: fix race condition between uie enable and rtc set time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221109064147.1836133-1-liaoyu15@huawei.com>
Date:   Wed, 9 Nov 2022 14:41:45 +0800
From:   Yu Liao <liaoyu15@...wei.com>
To:     <alexandre.belloni@...tlin.com>, <a.zummo@...ertech.it>
CC:     <liaoyu15@...wei.com>, <liwei391@...wei.com>,
        <linux-kernel@...r.kernel.org>, <linux-rtc@...r.kernel.org>
Subject: [PATCH v1 0/2] rtc: fix race condition between uie enable and rtc set time

The patch series fixes two issues in rtc_set_time caused by race
conditions:
- rtc_timer_do_work will loop for a while when setting rtc time in the
  future with uie enabled.
- RTC_UIE_OFF does not work when RTC_UIE_OFF and RTC_SET_TIME are
  running in parallel.

Patch #1 extracts lockless version from rtc_update_irq_enable, and
patch #2 addresses the race condition issue.

Changlog:

rfc -> V1:
1. fix smatch warnings reported by Dan Carpenter and kernel test robot:
	rtc_set_time() warn: inconsistent returns '&rtc->ops_lock'.

Yu Liao (2):
  rtc: add lockless rtc_update_irq_enable
  rtc: fix race condition in rtc_set_time()

 drivers/rtc/interface.c | 43 ++++++++++++++++++++++++-----------------
 1 file changed, 25 insertions(+), 18 deletions(-)

-- 
2.25.1