linux-kernel - Re: [PATCH] x86/paravirt: use common macro for creating simple asm paravirt functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <820ab144-5841-e3d9-88ec-52093f42be74@suse.com>
Date:   Wed, 9 Nov 2022 08:21:53 +0100
From:   Juergen Gross <jgross@...e.com>
To:     "Srivatsa S. Bhat" <srivatsa@...il.mit.edu>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org
Cc:     Alexey Makhalov <amakhalov@...are.com>,
        VMware PV-Drivers Reviewers <pv-drivers@...are.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>
Subject: Re: [PATCH] x86/paravirt: use common macro for creating simple asm
 paravirt functions

On 09.11.22 06:16, Srivatsa S. Bhat wrote:
> Hi Juergen,
> 
> Sorry for the delay in reviewing this patch!
> 
> On 10/20/22 2:19 AM, Juergen Gross wrote:
>> There are some paravirt assembler functions which are sharing a common
>> pattern. Introduce a macro DEFINE_PARAVIRT_ASM() for creating them.
>>
>> The explicit _paravirt_nop() prototype in paravirt.c isn't needed, as
>> it is included in paravirt_types.h already.
>>
>> Signed-off-by: Juergen Gross <jgross@...e.com>
> 
> I just wanted to make a note that the part of this patch that's not
> purely cleanup is the addition of the alignment (__ALIGN_STR) to
> __raw_callee_save___kvm_vcpu_is_preempted(), _paravirt_nop() and
> paravirt_ret0(). Maybe that's worth calling out in the commit message?

I can do that.

> 
> Reviewed-by: Srivatsa S. Bhat (VMware) <srivatsa@...il.mit.edu>

Thanks,


Juergen


Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)