linux-kernel - Re: [PATCH 00/13] arm64: defconfig: Enable missing kconfigs for mt8183-kukui-jacuzzi-juniper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 09 Nov 2022 08:28:50 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>,
        "Matthias Brugger" <matthias.bgg@...il.com>
Cc:     kernel@...labora.com,
        "AngeloGioacchino Del Regno" 
        <angelogioacchino.delregno@...labora.com>,
        "Bjorn Andersson" <andersson@...nel.org>,
        "Catalin Marinas" <catalin.marinas@....com>,
        "Dmitry Baryshkov" <dmitry.baryshkov@...aro.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski@...aro.org>,
        "Marcel Ziswiler" <marcel.ziswiler@...adex.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Shawn Guo" <shawnguo@...nel.org>, "Vinod Koul" <vkoul@...nel.org>,
        "Will Deacon" <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/13] arm64: defconfig: Enable missing kconfigs for
 mt8183-kukui-jacuzzi-juniper

On Wed, Nov 9, 2022, at 00:22, Nícolas F. R. A. Prado wrote:
> mt8183-kukui-jacuzzi-juniper is one of the devices set up to run tests
> on KernelCI, but several of its drivers are currently disabled in the
> defconfig. This series enables all the missing kconfigs on the defconfig
> to get everything probing on that machine so that it can be fully tested
> by KernelCI.

The changes all look fine, but I would recommend not separating it
out into 13 patches when you are doing just one thing here. 

As a general rule, if you keep saying the same things in each
patch description, it is usually an indication that they should
be combined. Similarly, if you find describing unrelated changes
("also, ..."), that would be an indication that patches should
be split up.

> Given that all kconfigs added in the series are to enable support for a
> MediaTek platform, it seems reasonable for it to be applied through the
> MediaTek tree, but the commits themselves are independent (apart from
> MTK_CMDQ and MTK_SVS) and could be applied separately.

Agreed, merging this through the Mediatek tree is the preferred way.

     Arnd