linux-kernel - Re: [PATCH v2] staging: fieldbus: replace snprintf in show functions with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2tXEibm2QxH37FK@kroah.com>
Date:   Wed, 9 Nov 2022 08:30:26 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Deepak R Varma <drv@...lo.com>
Cc:     outreachy@...ts.linux.dev, Sven Van Asbroeck <TheSven73@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: fieldbus: replace snprintf in show functions
 with sysfs_emit

On Wed, Nov 09, 2022 at 11:26:52AM +0530, Deepak R Varma wrote:
> The show() methods should only use sysfs_emit() when formatting values
> to be returned to the user space.
> Ref: Documentation/filesystems/sysfs.rst
> Issue identified by coccicheck.
> 
> Signed-off-by: Deepak R Varma <drv@...lo.com>
> ---
> 
> Changes in v2:
>    1. Switch to using sysfs_emit instead of scnprintf
>    2. Update patch subject and log accordingly
>       Feedback from gregkh@...uxfoundation.org
> 
> 
>  drivers/staging/fieldbus/dev_core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/fieldbus/dev_core.c b/drivers/staging/fieldbus/dev_core.c
> index 5aab734606ea..d32599f4eb44 100644
> --- a/drivers/staging/fieldbus/dev_core.c
> +++ b/drivers/staging/fieldbus/dev_core.c
> @@ -67,10 +67,10 @@ static ssize_t card_name_show(struct device *dev, struct device_attribute *attr,
>  	struct fieldbus_dev *fb = dev_get_drvdata(dev);
> 
>  	/*
> -	 * card_name was provided by child driver, could potentially be long.
> -	 * protect against buffer overrun.
> +	 * sysfs provides PAGE_SIZE long buffer to take care of potentially

No need to ever mention PAGE_SIZE at all, this comment should just be:
	/* card_name was provided by child driver */

But the larger question is, why did you only convert one of the sysfs
show functions in this file?  Why not do them all?

thanks,

greg k-h