[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221109093739.187-1-thunder.leizhen@huawei.com>
Date: Wed, 9 Nov 2022 17:37:36 +0800
From: Zhen Lei <thunder.leizhen@...wei.com>
To: "Paul E . McKenney" <paulmck@...nel.org>,
Frederic Weisbecker <frederic@...nel.org>,
Neeraj Upadhyay <quic_neeraju@...cinc.com>,
"Josh Triplett" <josh@...htriplett.org>,
Steven Rostedt <rostedt@...dmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Lai Jiangshan <jiangshanlai@...il.com>,
Joel Fernandes <joel@...lfernandes.org>, <rcu@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
CC: Zhen Lei <thunder.leizhen@...wei.com>,
Robert Elliott <elliott@....com>
Subject: [PATCH v6 0/2] rcu: Add RCU stall diagnosis information
v5 --> v6:
1. When there are more than two continuous RCU stallings, correctly handle the
value of the second and subsequent sampling periods. Update comments and
document.
Thanks to Elliott, Robert for the test.
2. Change "rcu stall" to "RCU stall".
v4 --> v5:
1. Resolve a git am conflict. No code change.
v3 --> v4:
1. Rename rcu_cpu_stall_deep_debug to rcu_cpu_stall_cputime.
v2 --> v3:
1. Fix the return type of kstat_cpu_irqs_sum()
2. Add Kconfig option CONFIG_RCU_CPU_STALL_DEEP_DEBUG and boot parameter
rcupdate.rcu_cpu_stall_deep_debug.
3. Add comments and normalize local variable name
v1 --> v2:
1. Fixed a bug in the code. If the rcu stall is detected by another CPU,
kcpustat_this_cpu cannot be used.
@@ -451,7 +451,7 @@ static void print_cpu_stat_info(int cpu)
if (r->gp_seq != rdp->gp_seq)
return;
- cpustat = kcpustat_this_cpu->cpustat;
+ cpustat = kcpustat_cpu(cpu).cpustat;
2. Move the start point of statistics from rcu_stall_kick_kthreads() to
rcu_implicit_dynticks_qs(), removing the dependency on irq_work.
v1:
In some extreme cases, such as the I/O pressure test, the CPU usage may
be 100%, causing RCU stall. In this case, the printed information about
current is not useful. Displays the number and usage of hard interrupts,
soft interrupts, and context switches that are generated within half of
the CPU stall timeout, can help us make a general judgment. In other
cases, we can preliminarily determine whether an infinite loop occurs
when local_irq, local_bh or preempt is disabled.
Zhen Lei (2):
rcu: Add RCU stall diagnosis information
doc: Document CONFIG_RCU_CPU_STALL_CPUTIME=y stall information
Documentation/RCU/stallwarn.rst | 88 +++++++++++++++++++
.../admin-guide/kernel-parameters.txt | 6 ++
kernel/rcu/Kconfig.debug | 11 +++
kernel/rcu/rcu.h | 1 +
kernel/rcu/tree.c | 17 ++++
kernel/rcu/tree.h | 19 ++++
kernel/rcu/tree_stall.h | 29 ++++++
kernel/rcu/update.c | 2 +
8 files changed, 173 insertions(+)
--
2.25.1
Powered by blists - more mailing lists