linux-kernel - RE: [PATCH 2/2] drm/display/dp_mst: Fix drm_dp_mst_add_affected_dsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Nov 2022 09:51:08 +0000
From:   "Lin, Wayne" <Wayne.Lin@....com>
To:     Lyude Paul <lyude@...hat.com>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Jani Nikula <jani.nikula@...el.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Imre Deak <imre.deak@...el.com>,
        Mikita Lipski <mikita.lipski@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] drm/display/dp_mst: Fix
 drm_dp_mst_add_affected_dsc_crtcs() return code

[AMD Official Use Only - General]

Hi Lyude,

It LGTM. Feel free to add 
Reviewed-by: Wayne Lin <Wayne.Lin@....com>

> -----Original Message-----
> From: Lyude Paul <lyude@...hat.com>
> Sent: Saturday, November 5, 2022 7:59 AM
> To: amd-gfx@...ts.freedesktop.org
> Cc: stable@...r.kernel.org; David Airlie <airlied@...il.com>; Daniel Vetter
> <daniel@...ll.ch>; Jani Nikula <jani.nikula@...el.com>; Thomas
> Zimmermann <tzimmermann@...e.de>; Lin, Wayne
> <Wayne.Lin@....com>; Imre Deak <imre.deak@...el.com>; Mikita Lipski
> <mikita.lipski@....com>; Deucher, Alexander
> <Alexander.Deucher@....com>; open list:DRM DRIVERS <dri-
> devel@...ts.freedesktop.org>; open list <linux-kernel@...r.kernel.org>
> Subject: [PATCH 2/2] drm/display/dp_mst: Fix
> drm_dp_mst_add_affected_dsc_crtcs() return code
> 
> Looks like that we're accidentally dropping a pretty important return code
> here. For some reason, we just return -EINVAL if we fail to get the MST
> topology state. This is wrong: error codes are important and should never be
> squashed without being handled, which here seems to have the potential to
> cause a deadlock.
> 
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> Fixes: 8ec046716ca8 ("drm/dp_mst: Add helper to trigger modeset on
> affected DSC MST CRTCs")
> Cc: <stable@...r.kernel.org> # v5.6+
> ---
>  drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index ecd22c038c8c0..51a46689cda70 100644
> --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> @@ -5186,7 +5186,7 @@ int drm_dp_mst_add_affected_dsc_crtcs(struct
> drm_atomic_state *state, struct drm
>  	mst_state = drm_atomic_get_mst_topology_state(state, mgr);
> 
>  	if (IS_ERR(mst_state))
> -		return -EINVAL;
> +		return PTR_ERR(mst_state);
> 
>  	list_for_each_entry(pos, &mst_state->payloads, next) {
> 
> --
> 2.37.3