linux-kernel - Re: [PATCH net 1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221108175531.1a7c16a6@kernel.org>
Date:   Tue, 8 Nov 2022 17:55:31 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michael Sit Wei Hong <michael.wei.hong.sit@...el.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Looi Hong Aun <hong.aun.looi@...el.com>,
        Voon Weifeng <weifeng.voon@...el.com>,
        Tan Tee Min <tee.min.tan@...el.com>,
        Zulkifli Muhammad Husaini <muhammad.husaini.zulkifli@...el.com>,
        Gan Yi Fang <yi.fang.gan@...el.com>
Subject: Re: [PATCH net 1/1] net: phy: dp83867: Fix SGMII FIFO depth for non
 OF devices

On Tue,  8 Nov 2022 18:12:18 +0800 Michael Sit Wei Hong wrote:
> Current driver code will read device tree node information,
> and set default values if there is no info provided.
> 
> This is not done in non-OF devices leading to SGMII fifo depths being
> set to the smallest size.
> 
> This patch sets the value to the default value of the PHY as stated in the
> PHY datasheet.

We need a Fixes tag, which commit should have contained this code?