linux-kernel - Re: [RFC PATCH v1 1/2] maccess: fix writing offset in case of fault in strncpy_from_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2655397.mvXUDI8C0e@pwmachine>
Date:   Wed, 09 Nov 2022 12:04:24 +0100
From:   Francis Laniel <flaniel@...ux.microsoft.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org,
        Alban Crequy <alban.crequy@...il.com>,
        Alban Crequy <albancrequy@...rosoft.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Mykola Lysenko <mykolal@...com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Shuah Khan <shuah@...nel.org>, linux-mm@...ck.org,
        bpf@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [RFC PATCH v1 1/2] maccess: fix writing offset in case of fault in strncpy_from_kernel_nofault()

Hi.

Le mardi 8 novembre 2022, 22:05:51 CET Andrew Morton a écrit :
> On Tue,  8 Nov 2022 20:52:06 +0100 Francis Laniel 
<flaniel@...ux.microsoft.com> wrote:
> > From: Alban Crequy <albancrequy@...rosoft.com>
> > 
> > If a page fault occurs while copying the first byte, this function resets
> > one byte before dst.
> > As a consequence, an address could be modified and leaded to kernel
> > crashes if case the modified address was accessed later.
> > 
> > Signed-off-by: Alban Crequy <albancrequy@...rosoft.com>
> > Tested-by: Francis Laniel <flaniel@...ux.microsoft.com>
> 
> Reviewed-by: Andrew Morton <akpm@...ux-foundation.org>
> 
> Please merge via the bpf tree.
> 
> This looks potentially nasty.  Fortunately only tracing code uses it,
> but I'm thinking it should have cc:stable and a Fixes:?

Thank you for the review!
Sorry, I thought to add stable list but forgot to add it when sending the 
series...
I will sent a v2 with your review and without rfc tag to, among others, 
stable.