[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <709daf8b-a58e-9247-c5d8-f3be3e60fe70@linaro.org>
Date: Wed, 9 Nov 2022 12:08:45 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Vivek Yadav <vivek.2311@...sung.com>, rcsekar@...sung.com,
krzysztof.kozlowski+dt@...aro.org, wg@...ndegger.com,
mkl@...gutronix.de, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, pankaj.dubey@...sung.com,
ravi.patel@...sung.com, alim.akhtar@...sung.com,
linux-fsd@...la.com, robh+dt@...nel.org
Cc: linux-can@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
aswani.reddy@...sung.com, sriranjani.p@...sung.com
Subject: Re: [PATCH v2 1/6] dt-bindings: Document the SYSREG specific
compatibles found on FSD SoC
On 09/11/2022 11:09, Vivek Yadav wrote:
> From: Sriranjani P <sriranjani.p@...sung.com>
>
Use subject prefixes matching the subsystem (git log --oneline -- ...).
> Describe the compatible properties for SYSREG controllers found on
> FSD SoC.
This is ARM SoC patch, split it from the patchset.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
> Signed-off-by: Pankaj Kumar Dubey <pankaj.dubey@...sung.com>
> Signed-off-by: Ravi Patel <ravi.patel@...sung.com>
> Signed-off-by: Vivek Yadav <vivek.2311@...sung.com>
> Cc: devicetree@...r.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> Cc: Rob Herring <robh+dt@...nel.org>
Drop the Cc list from commit log. It's not helpful.
> Signed-off-by: Sriranjani P <sriranjani.p@...sung.com>
> ---
> .../devicetree/bindings/arm/tesla-sysreg.yaml | 50 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/tesla-sysreg.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml
> new file mode 100644
> index 000000000000..bbcc6dd75918
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/tesla-sysreg.yaml
arm is only for top level stuff. This goes to soc under tesla or samsung
directory.
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/tesla-sysreg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Tesla Full Self-Driving platform's system registers
> +
> +maintainers:
> + - Alim Akhtar <alim.akhtar@...sung.com>
> +
> +description: |
> + This is a system control registers block, providing multiple low level
> + platform functions like board detection and identification, software
> + interrupt generation.
> +
> +properties:
> + compatible:
> + oneOf:
No need for oneOf.
> + - items:
> + - enum:
> + - tesla,sysreg_fsys0
> + - tesla,sysreg_peric
>From where did you get underscores in compatibles?
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + sysreg_fsys0: system-controller@...30000 {
> + compatible = "tesla,sysreg_fsys0", "syscon";
Use 4 spaces for example indentation.
> + reg = <0x0 0x15030000 0x0 0x1000>;
> + };
> +
> + sysreg_peric: system-controller@...30000 {
> + compatible = "tesla,sysreg_peric", "syscon";
> + reg = <0x0 0x14030000 0x0 0x1000>;
> + };
One example is enough, they are the same.
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a198da986146..56995e7d63ad 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2943,6 +2943,7 @@ M: linux-fsd@...la.com
> L: linux-arm-kernel@...ts.infradead.org (moderated for non-subscribers)
> L: linux-samsung-soc@...r.kernel.org
> S: Maintained
> +F: Documentation/devicetree/bindings/arm/tesla-sysreg.yaml
> F: arch/arm64/boot/dts/tesla*
>
> ARM/TETON BGA MACHINE SUPPORT
Best regards,
Krzysztof
Powered by blists - more mailing lists