linux-kernel - Re: [PATCH] PCI: qcom: Fix error message for reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2uKg2SAO2tvnisV@matsya>
Date:   Wed, 9 Nov 2022 16:39:55 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     lpieralisi@...nel.org, andersson@...nel.org, robh@...nel.org,
        kw@...ux.com, bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: qcom: Fix error message for reset_control_assert()

On 09-11-22, 15:10, Manivannan Sadhasivam wrote:
> Fix the error message to mention "assert" instead of "deassert".

Reviewed-by: Vinod Koul <vkoul@...nel.org>

> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
>  drivers/pci/controller/dwc/pcie-qcom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index f711acacaeaf..cf27345f6575 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -1236,7 +1236,7 @@ static int qcom_pcie_init_2_7_0(struct qcom_pcie *pcie)
>  
>  	ret = reset_control_assert(res->pci_reset);
>  	if (ret < 0) {
> -		dev_err(dev, "cannot deassert pci reset\n");
> +		dev_err(dev, "cannot assert pci reset\n");
>  		goto err_disable_clocks;
>  	}
>  
> -- 
> 2.25.1

-- 
~Vinod