[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y2uOd+mCwmh4qdm8@smile.fi.intel.com>
Date: Wed, 9 Nov 2022 13:26:47 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v1 1/2] resource: Replace printk(KERN_WARNING) by
pr_warn()
On Wed, Nov 09, 2022 at 12:12:03PM +0100, Rafael J. Wysocki wrote:
> On Wed, Nov 9, 2022 at 11:51 AM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > Replace printk(KERN_WARNING) by pr_warn().
> >
> > While at it, use %pa for the resource_size_t variables.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> This is Greg's stuff I think.
OK.
...
> > + resource_size_t end = addr + size - 1;
>
> And this change could be mentioned in the changelog too.
And it's (indirectly). This is to have a variable to be consistent in the
print. But I can add more explicit mention.
Thank you for a review!
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists