linux-kernel - Re: [6.1.0-rc3-next-20221104] Boot failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2uSH8jm1MzY9Rgf@linux.ibm.com>
Date:   Wed, 9 Nov 2022 13:42:23 +0200
From:   Mike Rapoport <rppt@...ux.ibm.com>
To:     Yajun Deng <yajun.deng@...ux.dev>
Cc:     Sachin Sant <sachinp@...ux.ibm.com>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        open list <linux-kernel@...r.kernel.org>, linux-mm@...ck.org
Subject: Re: [6.1.0-rc3-next-20221104] Boot failure - kernel BUG at
 mm/memblock.c:519

Hi Yajun,

On Wed, Nov 09, 2022 at 11:32:27AM +0000, Yajun Deng wrote:
> November 9, 2022 6:55 PM, "Sachin Sant" <sachinp@...ux.ibm.com> wrote:
> 
> >> On 09-Nov-2022, at 3:55 PM, Yajun Deng <yajun.deng@...ux.dev> wrote:
> >> 
> >> November 9, 2022 6:03 PM, "Yajun Deng" <yajun.deng@...ux.dev> wrote:
> >> 
> >>> Hey Mike,
> >> 
> >> Sorry, this email should be sent to Sachin but not Mike.
> >> Please forgive my confusion. So:
> >> 
> >> Hey Sachin,
> >> Can you help me test the attached file?
> >> Please use this new patch instead of the one in memblock tree.
> > 
> > Thanks for the fix. With the updated patch kernel boots correctly.
> > 
> 
> Thanks for your test results.
> 
> Hi Mike,
> Do you have any other suggestions for this patch? If not, I'll send a v3 patch.

Unfortunately I don't think the new version has much value as it does not
really eliminate the second loop in case memory allocation is required.
I'd say the improvement is not worth the churn.
 
> > Tested-by: Sachin Sant <sachinp@...ux.ibm.com <sachinp@...ux.ibm.com>>
> > 
> > - Sachin

-- 
Sincerely yours,
Mike.