linux-kernel - Re: [RFC PATCH] acpi: make remove callback of acpi driver void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdUrjjFqR-AzRs+fB4ruFqhES7k7Qommu7c=E5F8Oa80g@mail.gmail.com>
Date:   Wed, 9 Nov 2022 16:36:13 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Dawei Li <set_pte_at@...look.com>, rafael@...nel.org,
        u.kleine-koenig@...gutronix.de, dvhart@...radead.org,
        andy@...radead.org, lenb@...nel.org, arnd@...db.de,
        peterhuewe@....de, kys@...rosoft.com, kronos.it@...il.com,
        dmitry.torokhov@...il.com, bleung@...omium.org,
        sujith.thomas@...el.com, vithampi@...are.com, lee@...nel.org,
        wim@...ux-watchdog.org, jgross@...e.com, davem@...emloft.net,
        linux-acpi@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] acpi: make remove callback of acpi driver void

On Wed, Nov 9, 2022 at 3:45 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> On Sun, Nov 06, 2022 at 10:57:53PM +0800, Dawei Li wrote:
> > For bus-based driver, device removal is implemented as:
> > 1 device_remove()->
> > 2   bus->remove()->
> > 3     driver->remove()
> >
> > Driver core needs _no_ inform from callee(bus driver) about the
> > result of remove callback. In that case,
> > commit <fc7a6209d571> ("bus: Make remove callback return void")

Also please read Submitting Patches on how to provide a commit
reference in the message body.

> > forces struct bus_type::remove() be void-returned.
> >
> > Now we have the situation that both 1 & 2 of calling chain are
> > void-returned, so it does _not_ make much sense for 3(driver->remove)
> > to return non-void to its caller.
> >
> > So the basic idea behind this change is making remove() callback of
> > any bus-based driver to be void-returned.
> >
> > This change itself, is for device drivers based on acpi-bus.


-- 
With Best Regards,
Andy Shevchenko