linux-kernel - Re: [PATCH v6 1/2] soc: loongson: add GUTS driver for loongson-2 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <0b2ca852-61b2-4e88-b389-f102994d5b2d@app.fastmail.com>
Date:   Wed, 09 Nov 2022 16:08:28 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Huacai Chen" <chenhuacai@...nel.org>
Cc:     "Linus Walleij" <linus.walleij@...aro.org>,
        "Yinbo Zhu" <zhuyinbo@...ngson.cn>,
        "WANG Xuerui" <kernel@...0n.name>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        "Hector Martin" <marcan@...can.st>,
        "Lubomir Rintel" <lkundrak@...sk>,
        "Conor.Dooley" <conor.dooley@...rochip.com>,
        "Hitomi Hasegawa" <hasegawa-hitomi@...itsu.com>,
        Heiko Stübner <heiko@...ech.de>,
        "Brian Norris" <briannorris@...omium.org>,
        "Sven Peter" <sven@...npeter.dev>, loongarch@...ts.linux.dev,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        soc@...nel.org
Subject: Re: [PATCH v6 1/2] soc: loongson: add GUTS driver for loongson-2 platforms

On Wed, Nov 9, 2022, at 14:50, Huacai Chen wrote:
> On Wed, Nov 9, 2022 at 7:06 PM Arnd Bergmann <arnd@...db.de> wrote:
>> On Wed, Nov 9, 2022, at 11:15, Linus Walleij wrote:
>> > On Wed, Nov 9, 2022 at 11:03 AM Yinbo Zhu <zhuyinbo@...ngson.cn> wrote:
>> >
>> >> Hi maintainer,
>> >>
>> >> This patch I had verified that base on mainline 6.1-rc3 tree, it is
>> >> okay, if no other issue, please you help me merge it to upstream.
>> >
>> > Aren't these loongarch maintainers listed in MAINTAINERS able to
>> > merge this? Certainly Huacai can merge stuff to drivers/soc as
>> > need be. drivers/soc is a bit shared between different archs.
>>
>> I'm generally happy to keep an eye on stuff in drivers/soc/ across
>> architectures and merge it through the soc tree, especially for
>> new platforms, but merging this through the loongarch tree works
>> as well.
> So drivers/soc is similar to drivers/platform that can be merged
> through corresponding architecture trees?

Right, I think in both cases, there is no top-level subsystem
maintainer, but the rules are specific to the second-level
hierarchy: most parts of drivers/platform/ happen to go
through the x86 platform maintainer trees, and for drivers/soc
we merge most stuff through the soc tree, but a few parts
of each have different maintainers.

>> Since the driver was already sent to soc@...nel.org, I can
>> simply pick it up through patchwork[1] when I do my next round
>> of merges. I'll leave this up to Huacai Chen and WANG Xuerui,
>> let me know if you prefer to merge it through the loongarch
>> tree.
> I'm happy that this series be merged through your linux-arch tree, but
> if it is better (I'm not sure which is better) to go through loongarch
> tree I can also merge it later. However, I have some comments about
> this version. :)

I would prefer the soc tree, and will just apply the
patches from Yinbo Zhu directly this time as I already
have them in my queue. If there are more than a few
drivers/soc/loongarch/ patches in the future, maybe you can
pick them up into a separate branch and forward those
to soc@...nel.org.

Note that I have two separate roles here: I have the
asm-generic tree that I maintain for patches to
include/asm-generic as well as the occasional new
architecture review as I did for loongarch.

The other one is the group maintained soc tree that
is mainly for Arm device tree files, but also contains
soc specific code (arch/arm/mach-*), defconfig files,
drivers (drivers/{soc,firmware,memory,reset}). This is
now extended to arch/riscv and occasionally other
architectures as well, so drivers/soc/loongson fits
well in here.

     Arnd