lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <482c6af5-0b55-0e9d-0b1f-d22b9546f062@amd.com>
Date:   Wed, 9 Nov 2022 20:58:50 +0530
From:   Basavaraj Natikar <bnatikar@....com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Basavaraj Natikar <Basavaraj.Natikar@....com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] pinctrl: Put space between type and data in
 compound literal



On 11/9/2022 8:53 PM, Andy Shevchenko wrote:
> It's slightly better to read when compound literal data and type
> are separated by a space.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>
> It also standard practice in the kernel:
>
> $ git grep -l '(struct [^()]\+) {' | wc -l
> 1384
>
> $ git grep -l '(struct [^()]\+){' | wc -l
> 306
>
>  include/linux/pinctrl/pinctrl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h
> index 487117ccb1bc..f6ff2590657d 100644
> --- a/include/linux/pinctrl/pinctrl.h
> +++ b/include/linux/pinctrl/pinctrl.h
> @@ -40,7 +40,7 @@ struct pingroup {
>  
>  /* Convenience macro to define a single named or anonymous pingroup */
>  #define PINCTRL_PINGROUP(_name, _pins, _npins)	\
> -(struct pingroup){				\
> +(struct pingroup) {				\
>  	.name = _name,				\
>  	.pins = _pins,				\
>  	.npins = _npins,			\

Looks good to me

Reviewed-by: Basavaraj Natikar <Basavaraj.Natikar@....com>

Thanks,
--
Basavaraj

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ