linux-kernel - Re: [PATCH] platform: use fwnode_irq_get_byname instead of of_irq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y207AeWA1LYvVKwI@kroah.com>
Date:   Thu, 10 Nov 2022 18:55:13 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     soha@...u.info
Cc:     rafael@...nel.org, linux-kernel@...r.kernel.org,
        'Wende Tan' <twd2.me@...il.com>
Subject: Re: [PATCH] platform: use fwnode_irq_get_byname instead of
 of_irq_get_byname to get irq

On Sat, Oct 01, 2022 at 02:15:29AM +0800, soha@...u.info wrote:
> >From 02df97f4d814b9893eef2c2118b85d2b4b9d61ae Mon Sep 17 00:00:00 2001
> From: Soha Jin <soha@...u.info>
> Date: Sat, 1 Oct 2022 00:26:04 +0800
> Subject: [PATCH] platform: use fwnode_irq_get_byname instead of
>  of_irq_get_byname to get irq
> 
> Not only platform devices described by OF have named interrupts, but
> devices described by ACPI also have named interrupts. The fwnode is an
> abstraction to different standards, and using fwnode_irq_get_byname can
> support more devices.
> 
> Signed-off-by: Soha Jin <soha@...u.info>
> Tested-by: Wende Tan <twd2.me@...il.com>
> ---
>  drivers/base/platform.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index 51bb22898..968f3d71e 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -441,8 +441,8 @@ static int __platform_get_irq_byname(struct platform_device *dev,
>  	struct resource *r;
>  	int ret;
>  
> -	if (IS_ENABLED(CONFIG_OF_IRQ) && dev->dev.of_node) {
> -		ret = of_irq_get_byname(dev->dev.of_node, name);
> +	if (!dev->dev.of_node || IS_ENABLED(CONFIG_OF_IRQ)) {
> +		ret = fwnode_irq_get_byname(dev_fwnode(&dev->dev), name);
>  		if (ret > 0 || ret == -EPROBE_DEFER)
>  			return ret;
>  	}
> -- 
> 2.30.2
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot