linux-kernel - Re: [PATCH v3 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for quad-uart support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Nov 2022 19:06:39 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kumaravel.Thiagarajan@...rochip.com
Cc:     linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        jirislaby@...nel.org, andriy.shevchenko@...ux.intel.com,
        ilpo.jarvinen@...ux.intel.com, macro@...am.me.uk,
        jay.dolan@...esio.com, cang1@...e.co.uk,
        u.kleine-koenig@...gutronix.de, wander@...hat.com,
        etremblay@...tech-controls.com, jk@...abs.org,
        biju.das.jz@...renesas.com, geert+renesas@...der.be,
        phil.edworthy@...esas.com, lukas@...ner.de,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v3 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver
 for quad-uart support.

On Thu, Nov 10, 2022 at 05:18:46PM +0000, Kumaravel.Thiagarajan@...rochip.com wrote:
> > -----Original Message-----
> > From: Greg KH <gregkh@...uxfoundation.org>
> > Sent: Wednesday, November 9, 2022 5:31 PM
> > To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@...rochip.com>
> > Subject: Re: [PATCH v3 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for
> > quad-uart support.
> >  
> > On Mon, Nov 07, 2022 at 06:15:15PM +0530, Kumaravel Thiagarajan wrote:
> > > +++ b/drivers/tty/serial/8250/8250_pcilib.c
> > > @@ -0,0 +1,31 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/* Microchip pci1xxxx 8250 library. */
> > 
> > Better name and a copyright line?
> Yes Greg. I think "8250 PCI library" would be the correct name. Is that fine?

That would be good as obviously it's not a microchip-only thing here.

> Regarding the copyright, we moved the "setup_port" function from 8250_pci.c to this new file.
> Can I use the same copyright statement from 8250_pci.c "Copyright (C) 2001 Russell King, All Rights Reserved."?

Yes, that would be good.

thanks,

greg k-h