linux-kernel - Re: [PATCH v2 2/2] x86: Check return values from early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd5aabe0-94a6-3832-9e3e-b308b134d7e8@oracle.com>
Date:   Thu, 10 Nov 2022 14:31:45 -0500
From:   Ross Philipson <ross.philipson@...cle.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        dpsmith@...rtussolutions.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, hpa@...or.com, luto@...capital.net,
        dave.hansen@...ux.intel.com, kanth.ghatraju@...cle.com,
        trenchboot-devel@...glegroups.com, jailhouse-dev@...glegroups.com,
        jan.kiszka@...mens.com, xen-devel@...ts.xenproject.org,
        jgross@...e.com, boris.ostrovsky@...cle.com,
        andrew.cooper3@...rix.com
Subject: Re: [PATCH v2 2/2] x86: Check return values from early_ioremap calls

On 11/10/22 13:07, Peter Zijlstra wrote:
> On Thu, Nov 10, 2022 at 03:45:21PM +0000, Ross Philipson wrote:
>> On allocation failures, panic() was used since this seemed
>> to be the action taken on other failures in the modules
>> touched by this patch.
> 
> How is the panic() more useful than the obvious NULL deref that also
> splats?
> 

My answer here is basically the same as the answer in the reply to Dave 
Hansen I sent a moment ago. I think one of the primary motivation was to 
make things consistent.

Thanks
Ross