lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Nov 2022 23:13:49 +0300 From: Dmitry Osipenko <dmitry.osipenko@...labora.com> To: Sumit Semwal <sumit.semwal@...aro.org>, Christian König <christian.koenig@....com>, Benjamin Gaignard <benjamin.gaignard@...labora.com>, Liam Mark <lmark@...eaurora.org>, Brian Starkey <Brian.Starkey@....com>, John Stultz <jstultz@...gle.com>, Gerd Hoffmann <kraxel@...hat.com>, Daniel Vetter <daniel@...ll.ch>, Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>, Thomas Zimmermann <tzimmermann@...e.de>, Tomi Valkeinen <tomba@...nel.org>, Thierry Reding <thierry.reding@...il.com>, Tomasz Figa <tfiga@...omium.org>, Marek Szyprowski <m.szyprowski@...sung.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Amol Maheshwari <amahesh@....qualcomm.com> Cc: linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, intel-gfx@...ts.freedesktop.org, linux-tegra@...r.kernel.org, linux-arm-msm@...r.kernel.org, kernel@...labora.com Subject: [PATCH v1 6/6] fastrpc: Assert held reservation lock for dma-buf mmapping When userspace mmaps dma-buf's fd, the dma-buf reservation lock must be held. Add locking sanity check to the dma-buf mmaping callback to ensure that the locking assumption won't regress in the future. Suggested-by: Daniel Vetter <daniel@...ll.ch> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@...labora.com> --- drivers/misc/fastrpc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 1ad580865525..0f467a71b069 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -6,6 +6,7 @@ #include <linux/device.h> #include <linux/dma-buf.h> #include <linux/dma-mapping.h> +#include <linux/dma-resv.h> #include <linux/idr.h> #include <linux/list.h> #include <linux/miscdevice.h> @@ -682,6 +683,8 @@ static int fastrpc_mmap(struct dma_buf *dmabuf, struct fastrpc_buf *buf = dmabuf->priv; size_t size = vma->vm_end - vma->vm_start; + dma_resv_assert_held(dmabuf->resv); + return dma_mmap_coherent(buf->dev, vma, buf->virt, FASTRPC_PHYS(buf->phys), size); } -- 2.37.3
Powered by blists - more mailing lists