[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20221110131636.1097802c.alex.williamson@redhat.com>
Date: Thu, 10 Nov 2022 13:16:36 -0700
From: Alex Williamson <alex.williamson@...hat.com>
To: Rafael Mendonca <rafaelmendsr@...il.com>
Cc: Eric Auger <eric.auger@...hat.com>,
Cornelia Huck <cohuck@...hat.com>,
Sinan Kaya <okaya@...eaurora.org>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfio: platform: Do not pass return buffer to ACPI _RST
method
On Tue, 18 Oct 2022 12:28:25 -0300
Rafael Mendonca <rafaelmendsr@...il.com> wrote:
> The ACPI _RST method has no return value, there's no need to pass a return
> buffer to acpi_evaluate_object().
>
> Fixes: d30daa33ec1d ("vfio: platform: call _RST method when using ACPI")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@...il.com>
> ---
> drivers/vfio/platform/vfio_platform_common.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> index 55dc4f43c31e..1a0a238ffa35 100644
> --- a/drivers/vfio/platform/vfio_platform_common.c
> +++ b/drivers/vfio/platform/vfio_platform_common.c
> @@ -72,12 +72,11 @@ static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,
> const char **extra_dbg)
> {
> #ifdef CONFIG_ACPI
> - struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> struct device *dev = vdev->device;
> acpi_handle handle = ACPI_HANDLE(dev);
> acpi_status acpi_ret;
>
> - acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, &buffer);
> + acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, NULL);
> if (ACPI_FAILURE(acpi_ret)) {
> if (extra_dbg)
> *extra_dbg = acpi_format_exception(acpi_ret);
Applied to vfio next branch for v6.2. Thanks,
Alex
Powered by blists - more mailing lists