linux-kernel - Re: linux-next: build warning after merge of the mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Nov 2022 12:20:40 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>
Subject: Re: linux-next: build warning after merge of the mm tree

[adding linux-doc]

On 11/10/22 08:27, Linus Torvalds wrote:
> On Wed, Nov 9, 2022 at 11:33 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>>
>> After merging the mm tree, today's linux-next build (htmldocs) produced
>> this warning:
>>
>> include/linux/mm_types.h:268: error: Cannot parse struct or union!
> 
> Good on you. You check the docs warnings, I've given up on them
> because there's so many and it takes so long.
> 
> I tried to document the 'struct encoded_page' the same way 'struct
> folio' was documented, but clearly the docs parsing hates it. Let's
> remove the '/**' marker and just make it a regular comment.

Yep, that works. Or adding this works:
-struct encoded_page;
+struct encoded_page {
+};

although it shouldn't be needed.

> The same goes for the 'release_pages()' thing,

Looks like scripts/kernel-doc is deficient in parsing

struct encoded_page;

without having any { ... }

and it doesn't handle "typedef union" or "typedef struct". :(

-- 
~Randy