linux-kernel - Re: [PATCH v1 1/1]: iio: light: rpr0521: add missing Kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221110204322.waygj3v466haadmr@device>
Date:   Thu, 10 Nov 2022 15:43:22 -0500
From:   Paul Gazzillo <paul@...zz.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Shreeya Patel <shreeya.patel@...labora.com>,
        Zhigang Shi <Zhigang.Shi@...eon.com>,
        Dmitry Osipenko <dmitry.osipenko@...labora.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1]: iio: light: rpr0521: add missing Kconfig
 dependencies


On 11/10/2022, Andy Shevchenko wrote:
> On Thu, Nov 10, 2022 at 09:44:48AM -0500, Paul Gazzillo wrote:
> 
> >     CC      drivers/iio/light/rpr0521.o
> >   drivers/iio/light/rpr0521.c: In function 'rpr0521_drdy_irq_thread':
> 
> These two lines can be removed.

Will do.

> > (This bug was found with the help of a tool, krepair, that generates
> > configuration files for commits: https://github.com/paulgazz/kmax)
> 
> I'm not sure we need this in the commit message. Do we have a tag for
> the static analyzers?

I'll also remove this.

> > The following patch ensures that the code controlled by IIO_BUFFER and
> > IIO_TRIGGERED_BUFFER is available:
> 
> > Reported-by: Paul Gazzillo <paul@...zz.com>
> 
> Without SoB this may not be anyhow proceeded. Please, read Submitting Patches
> documentation and try again.
> 
> (Btw, Reported-by above contradicts the commit message that refers to the tool,
>  and not human)

Apologies, I was confused about whether I or the maintainer fills that
out.  Will submit a new version with SoB.

Thanks!
Paul

> 
> -- 
> With Best Regards,
> Andy Shevchenko