[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d60c475e-89c2-37e1-15f6-502598f36156@redhat.com>
Date: Thu, 10 Nov 2022 22:33:44 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: Jithu Joseph <jithu.joseph@...el.com>, markgross@...nel.org
Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
gregkh@...uxfoundation.org, ashok.raj@...el.com,
tony.luck@...el.com, linux-kernel@...r.kernel.org,
platform-driver-x86@...r.kernel.org, patches@...ts.linux.dev,
ravi.v.shankar@...el.com, thiago.macieira@...el.com,
athenas.jimenez.gonzalez@...el.com, sohil.mehta@...el.com
Subject: Re: [PATCH v2 13/14] Documentation/ABI: Update IFS ABI doc
Hi,
On 11/7/22 23:53, Jithu Joseph wrote:
> Remove reload documentation and add current_batch documentation.
> Update the kernel version and date for all the entries.
>
> Reviewed-by: Tony Luck <tony.luck@...el.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@...el.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@...hat.com>
Regards,
Hans
> ---
> .../ABI/testing/sysfs-platform-intel-ifs | 30 ++++++++++---------
> 1 file changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-platform-intel-ifs b/Documentation/ABI/testing/sysfs-platform-intel-ifs
> index 486d6d2ff8a0..f74df3abee57 100644
> --- a/Documentation/ABI/testing/sysfs-platform-intel-ifs
> +++ b/Documentation/ABI/testing/sysfs-platform-intel-ifs
> @@ -1,39 +1,41 @@
> What: /sys/devices/virtual/misc/intel_ifs_<N>/run_test
> -Date: April 21 2022
> -KernelVersion: 5.19
> +Date: Sept 30 2022
> +KernelVersion: 6.2
> Contact: "Jithu Joseph" <jithu.joseph@...el.com>
> Description: Write <cpu#> to trigger IFS test for one online core.
> Note that the test is per core. The cpu# can be
> for any thread on the core. Running on one thread
> completes the test for the core containing that thread.
> Example: to test the core containing cpu5: echo 5 >
> - /sys/devices/platform/intel_ifs.<N>/run_test
> + /sys/devices/virtual/misc/intel_ifs_<N>/run_test
>
> What: /sys/devices/virtual/misc/intel_ifs_<N>/status
> -Date: April 21 2022
> -KernelVersion: 5.19
> +Date: Sept 30 2022
> +KernelVersion: 6.2
> Contact: "Jithu Joseph" <jithu.joseph@...el.com>
> Description: The status of the last test. It can be one of "pass", "fail"
> or "untested".
>
> What: /sys/devices/virtual/misc/intel_ifs_<N>/details
> -Date: April 21 2022
> -KernelVersion: 5.19
> +Date: Sept 30 2022
> +KernelVersion: 6.2
> Contact: "Jithu Joseph" <jithu.joseph@...el.com>
> Description: Additional information regarding the last test. The details file reports
> the hex value of the SCAN_STATUS MSR. Note that the error_code field
> may contain driver defined software code not defined in the Intel SDM.
>
> What: /sys/devices/virtual/misc/intel_ifs_<N>/image_version
> -Date: April 21 2022
> -KernelVersion: 5.19
> +Date: Sept 30 2022
> +KernelVersion: 6.2
> Contact: "Jithu Joseph" <jithu.joseph@...el.com>
> Description: Version (hexadecimal) of loaded IFS binary image. If no scan image
> is loaded reports "none".
>
> -What: /sys/devices/virtual/misc/intel_ifs_<N>/reload
> -Date: April 21 2022
> -KernelVersion: 5.19
> +What: /sys/devices/virtual/misc/intel_ifs_<N>/current_batch
> +Date: Sept 30 2022
> +KernelVersion: 6.2
> Contact: "Jithu Joseph" <jithu.joseph@...el.com>
> -Description: Write "1" (or "y" or "Y") to reload the IFS image from
> - /lib/firmware/intel/ifs/ff-mm-ss.scan.
> +Description: Write a number less than or equal to 0xff to load an IFS test image.
> + The number written treated as the 2 digit suffix in the following file name:
> + /lib/firmware/intel/ifs_<N>/ff-mm-ss-02x.scan
> + Reading the file will provide the suffix of the currently loaded IFS test image.
Powered by blists - more mailing lists