[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y2x2V7QoGQXbzycc@bombadil.infradead.org>
Date: Wed, 9 Nov 2022 19:56:07 -0800
From: Luis Chamberlain <mcgrof@...nel.org>
To: Nick Alcock <nick.alcock@...cle.com>,
Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org,
arnd@...db.de, akpm@...ux-foundation.org, eugene.loh@...cle.com,
kris.van.hees@...cle.com, mcgrof@...nel.org
Subject: Re: [PATCH v9 1/8] kbuild: bring back tristate.conf
On Wed, Nov 09, 2022 at 01:41:25PM +0000, Nick Alcock wrote:
> tristate.conf was dropped because it is not needed to build a
> modules.builtin (although dropping it introduces a few false positives
> into modules.builtin support), and doing so avoids one round of
> recursion through the build tree to build it. But kallmodsyms support
> requires building a mapping from object file name to built-in module
> name for all builtin modules: this seems to me impossible to accomplish
> without parsing all makefiles under the influence of tristate.conf,
> since the makefiles are the only place this mapping is recorded.
>
> So bring it back for this purpose. (Thanks to the refactoring in
> the 5.16 timeframe, this is basically a reimplementation of commit
> 8b41fc4454e36fbfdbb23f940d023d4dece2de29 rather than a simple
> reversion.)
>
> Signed-off-by: Nick Alcock <nick.alcock@...cle.com>
> Reviewed-by: Victor Erminpour <victor.erminpour@...cle.com>
> Reviewed-by: Kris Van Hees <kris.van.hees@...cle.com>
I don't see the need, see the review of next patch.
Luis
Powered by blists - more mailing lists